gh-131798: JIT: Narrow the return type of _BINARY_OP_SUBSCR_STR_INT to str#132153
Merged
brandtbucher merged 3 commits intopython:mainfrom Apr 8, 2025
Merged
gh-131798: JIT: Narrow the return type of _BINARY_OP_SUBSCR_STR_INT to str#132153brandtbucher merged 3 commits intopython:mainfrom
_BINARY_OP_SUBSCR_STR_INT to str#132153brandtbucher merged 3 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this by finding another instruction which contains a unicode guard, in this case
BINARY_OP_ADD_UNICODEand checking that the guard is removed if one of the operands is the result of_BINARY_OP_SUBSCR_STR_INT. Let me know if there's a better way to test this!I also noticed that some other uops like
_BINARY_OP_ADD_UNICODEcheck if the operands are constants. Should we add it here as well? I don't know if we gain much from that though, code like'foo'[0]is not very common.